mihaibudiu commented on code in PR #4214:
URL: https://github.com/apache/calcite/pull/4214#discussion_r2023859035
##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -93,6 +94,18 @@ public StarRocksSqlDialect(Context context) {
return true;
}
+ @Override public boolean supportsUnparseOnlyDeterministic(SqlOperator
sqlOperator) {
Review Comment:
I am not sure this function is useful.
If the function returns 'false' and you cannot unparse, you will need to
throw.
If you remove the function, you still throw in the same places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
