mihaibudiu commented on code in PR #4719:
URL: https://github.com/apache/calcite/pull/4719#discussion_r2674498398
##########
core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java:
##########
@@ -200,6 +200,20 @@ public MssqlSqlDialect(Context context) {
unparseBoolLiteralToCondition(writer, value);
}
+ @Override public SqlNode rewriteBooleanLiteral(SqlNode node, boolean
expressionAllowed) {
Review Comment:
I can see that my suggestion was not good, because RelToSqlConverter does
not know whether an expression is allowed - only the dialect does. The
SqlToRelConverter would need instead to pass some more information, like the
parent Rel node.
So you either have to remove this boolean, reverting to the previous
solution, or add more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
