xiedeyantu commented on code in PR #4719:
URL: https://github.com/apache/calcite/pull/4719#discussion_r2674621246
##########
core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java:
##########
@@ -200,6 +200,20 @@ public MssqlSqlDialect(Context context) {
unparseBoolLiteralToCondition(writer, value);
}
+ @Override public SqlNode rewriteBooleanLiteral(SqlNode node, boolean
expressionAllowed) {
Review Comment:
I only previously introduced RelNode in supportGenerateSelectStar, and this
is used to check for duplicate column names; I haven't rewritten the logic. If
we can accept changing TRUE to 1 and FALSE to 0, then I think the current
implementation might be okay, but it's certainly not very aesthetically
pleasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
