mihaibudiu commented on code in PR #4719:
URL: https://github.com/apache/calcite/pull/4719#discussion_r2674524251
##########
core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java:
##########
@@ -200,6 +200,20 @@ public MssqlSqlDialect(Context context) {
unparseBoolLiteralToCondition(writer, value);
}
+ @Override public SqlNode rewriteBooleanLiteral(SqlNode node, boolean
expressionAllowed) {
Review Comment:
That should not be a problem, right? The MSSQL dialect can look at the Rel
node and decide that for SELECT and VALUES to emit an integer.
The question is whether it's a layering violation to pass Rel node
information to the dialect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
