mihaibudiu commented on code in PR #4719:
URL: https://github.com/apache/calcite/pull/4719#discussion_r2674512923
##########
core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java:
##########
@@ -200,6 +200,20 @@ public MssqlSqlDialect(Context context) {
unparseBoolLiteralToCondition(writer, value);
}
+ @Override public SqlNode rewriteBooleanLiteral(SqlNode node, boolean
expressionAllowed) {
Review Comment:
Are there any other methods that pass Rel nodes to the dialect?
If not, please just revert.
Otherwise maybe the dialect can get the Rel node and emit an integer in
VALUES and an expression otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
