xiedeyantu commented on code in PR #4719:
URL: https://github.com/apache/calcite/pull/4719#discussion_r2674509832
##########
core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java:
##########
@@ -200,6 +200,20 @@ public MssqlSqlDialect(Context context) {
unparseBoolLiteralToCondition(writer, value);
}
+ @Override public SqlNode rewriteBooleanLiteral(SqlNode node, boolean
expressionAllowed) {
Review Comment:
Should I revert to the original method? Indeed, this needs to be determined
at the dialect level, so the previous Java doc seems necessary, in case later
users see this method and don't understand what it does. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
