xiedeyantu commented on code in PR #4719:
URL: https://github.com/apache/calcite/pull/4719#discussion_r2674534283
##########
core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java:
##########
@@ -200,6 +200,20 @@ public MssqlSqlDialect(Context context) {
unparseBoolLiteralToCondition(writer, value);
}
+ @Override public SqlNode rewriteBooleanLiteral(SqlNode node, boolean
expressionAllowed) {
Review Comment:
I don't think obtaining the RelNode is a problem, but I feel that this would
involve some redundant rewriting in the Mssql dialect. I'm not sure if this
looks good, and it might even require introducing more input parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
