weizhouapache commented on code in PR #8765:
URL: https://github.com/apache/cloudstack/pull/8765#discussion_r1518051570
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2578,7 +2579,13 @@ protected void finalizeNetworkRulesForNetwork(final
Commands cmds, final DomainR
}
}
- final List<LoadBalancerVO> lbs =
_loadBalancerDao.listByNetworkIdAndScheme(guestNetworkId, Scheme.Public);
+ List<LoadBalancerVO> lbs = null;
+ Long vpcId = guestNetwork.getVpcId();
+ if (vpcId != null) {
+ lbs = _loadBalancerDao.listByVpcIdAndScheme(vpcId,
Scheme.Public);
Review Comment:
LB rules will be applied multiple times (=number of vpc tiers). There might
be exceptions as some guest nics are missing.
It can be applied when all guest nics are added to the VPC VR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
