SadiJr commented on code in PR #8765:
URL: https://github.com/apache/cloudstack/pull/8765#discussion_r1521420585
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2578,7 +2579,13 @@ protected void finalizeNetworkRulesForNetwork(final
Commands cmds, final DomainR
}
}
- final List<LoadBalancerVO> lbs =
_loadBalancerDao.listByNetworkIdAndScheme(guestNetworkId, Scheme.Public);
+ List<LoadBalancerVO> lbs = null;
+ Long vpcId = guestNetwork.getVpcId();
+ if (vpcId != null) {
+ lbs = _loadBalancerDao.listByVpcIdAndScheme(vpcId,
Scheme.Public);
Review Comment:
I'm not sure if I understood exactly what you meant; since LB rules are
being searched for by VPC ID, exceptions should not occur if there are missing
NICs. In the worst case, there will be a rule added to VR of one network that
does not exists.
Regarding applying the rules when all guest networks are added to VR, from
what I saw of the current ACS workflow, the solution I presented corrects the
problem, and I didn't find another part of the code where it can be solved
besides this section. If you think that this solution could be applied to
another section, could you please point to where that would be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
