weizhouapache commented on code in PR #8765:
URL: https://github.com/apache/cloudstack/pull/8765#discussion_r1521456790
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2578,7 +2579,13 @@ protected void finalizeNetworkRulesForNetwork(final
Commands cmds, final DomainR
}
}
- final List<LoadBalancerVO> lbs =
_loadBalancerDao.listByNetworkIdAndScheme(guestNetworkId, Scheme.Public);
+ List<LoadBalancerVO> lbs = null;
+ Long vpcId = guestNetwork.getVpcId();
+ if (vpcId != null) {
+ lbs = _loadBalancerDao.listByVpcIdAndScheme(vpcId,
Scheme.Public);
Review Comment:
@SadiJr
the method `finalizeNetworkRulesForNetwork` is called for each guest network
when VPC VR is started
https://github.com/apache/cloudstack/blob/706f3f6ab429be888f982c72e08689b99b9a428e/server/src/main/java/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java#L507-L523
If you search for `StartCommand` in management server logs, you will see
multiple `LoadBalancerConfigCommand` with same parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
