rhtyd commented on a change in pull request #4529:
URL: https://github.com/apache/cloudstack/pull/4529#discussion_r540782271
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -196,6 +203,9 @@ def add(self, entry):
self.dhcp_opts.add("%s,%s" % (tag, 3))
self.dhcp_opts.add("%s,%s" % (tag, 6))
self.dhcp_opts.add("%s,%s" % (tag, 15))
+ self.dhcp_leases.search(entry['mac_address'], "0 %s %s %s *" %
(entry['mac_address'],
Review comment:
same as above - can you check if the lease should have a high expiry
(80yrs or inf?) instead of `*`, I'm not sure what 0 and `*` mean here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
