davidjumani commented on a change in pull request #4529:
URL: https://github.com/apache/cloudstack/pull/4529#discussion_r540783505
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -196,6 +203,9 @@ def add(self, entry):
self.dhcp_opts.add("%s,%s" % (tag, 3))
self.dhcp_opts.add("%s,%s" % (tag, 6))
self.dhcp_opts.add("%s,%s" % (tag, 15))
+ self.dhcp_leases.search(entry['mac_address'], "0 %s %s %s *" %
(entry['mac_address'],
Review comment:
0 is infinite lease time (generally the epoch when the lease expires), *
is the client id (which is generally the mac, but can change)
Taken this format from existing leases file
https://dnsmasq-discuss.thekelleys.org.narkive.com/ia9YNLmE/dnsmasq-leases-file-format-specification
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
