davidjumani commented on a change in pull request #4529:
URL: https://github.com/apache/cloudstack/pull/4529#discussion_r540816633
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -60,6 +61,9 @@ def process(self):
if self.cloud.commit():
restart_dnsmasq = True
+ if self.dhcp_leases.commit():
+ restart_dnsmasq = True
Review comment:
From what I could see at
https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/cs/CsFile.py#L58,
a commit returns a boolean value of whether the file has changed, so if it
tries to add a host which already exists in the file, it shouldn't restart
dnsmasq
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
