weizhouapache commented on a change in pull request #4529:
URL: https://github.com/apache/cloudstack/pull/4529#discussion_r540813622
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -60,6 +61,9 @@ def process(self):
if self.cloud.commit():
restart_dnsmasq = True
+ if self.dhcp_leases.commit():
+ restart_dnsmasq = True
Review comment:
@rhtyd @davidjumani
the only issue I see is, dnsmasq will be restarted each time when
conf/host/dhcp lease is changed.
if there are many vms in the network, might it be a problem ?
it is not caused by this pr , but the line above
```
if self.cloud.commit():
restart_dnsmasq = True
```
might it be better to restart dnsmasq when all are processed ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
