weizhouapache commented on a change in pull request #4529:
URL: https://github.com/apache/cloudstack/pull/4529#discussion_r540817846
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -60,6 +61,9 @@ def process(self):
if self.cloud.commit():
restart_dnsmasq = True
+ if self.dhcp_leases.commit():
+ restart_dnsmasq = True
Review comment:
@rhtyd @davidjumani no worries, it looks good.
```
2020-12-11 09:39:48,228 INFO Processing JSON file cmd_line.json
2020-12-11 09:39:49,165 INFO Wrote edited file /etc/dnsmasq.d/cloud.conf
2020-12-11 09:39:49,166 INFO Nothing to commit. The
/var/lib/misc/dnsmasq.leases file did not change
2020-12-11 09:39:49,166 INFO Attempting to delete entries from
dnsmasq.leases file for VMs which are not on dhcphosts file
2020-12-11 09:39:49,167 ERROR Caught error while trying to delete entries
from dnsmasq.leases file: [Errno 2] No such file or directory:
'/etc/dhcphosts.txt'
2020-12-11 09:39:49,168 INFO Executing: systemctl restart dnsmasq
2020-12-11 09:39:49,704 INFO Service dnsmasq restart
2020-12-11 09:39:49,795 INFO Nothing to commit. The
/etc/dnsmasq.d/cloud.conf file did not change
2020-12-11 09:39:49,795 INFO Nothing to commit. The
/var/lib/misc/dnsmasq.leases file did not change
2020-12-11 09:39:49,795 INFO Executing: systemctl is-active dnsmasq
2020-12-11 09:39:49,820 INFO Executing: systemctl reload dnsmasq
2020-12-11 09:39:49,878 INFO Service dnsmasq reload
2020-12-11 09:40:11,302 INFO Processing JSON file
ip_associations.json.a72a28ec-caed-4f3a-908f-e8d8df726d57
2020-12-11 09:40:11,910 INFO Processing JSON file
monitor_service.json.335af30e-fd9e-44b1-a6c0-248a98c480db
2020-12-11 09:40:12,587 INFO Processing JSON file
vm_dhcp_entry.json.afaa3985-b0e0-4f2f-bd73-f61282006e0e
2020-12-11 09:40:12,794 INFO Processing JSON file
vm_dhcp_entry.json.fbba4e25-3569-4513-99ab-39d9f38a80d2
2020-12-11 09:40:13,129 INFO Processing JSON file
vm_dhcp_entry.json.b6a1f368-180b-4a48-b664-22aa8e89cfba
2020-12-11 09:40:13,530 INFO Processing JSON file
vm_metadata.json.ab86c2c2-acfc-4d01-8e4b-bd11ae7101ed
2020-12-11 09:40:13,993 INFO Processing JSON file
vm_metadata.json.8750a124-ba49-4fb5-8484-50ff65971f9a
2020-12-11 09:40:14,256 INFO Processing JSON file
vm_metadata.json.72e3d268-5e11-4bcd-a693-ab8fc599718b
2020-12-11 09:40:14,713 INFO Wrote edited file /etc/dnsmasq.d/cloud.conf
2020-12-11 09:40:14,714 INFO Wrote edited file
/var/lib/misc/dnsmasq.leases
2020-12-11 09:40:14,715 INFO Attempting to delete entries from
dnsmasq.leases file for VMs which are not on dhcphosts file
2020-12-11 09:40:14,724 INFO Deleted 0 entries from dnsmasq.leases file
2020-12-11 09:40:14,725 INFO Executing: systemctl restart dnsmasq
2020-12-11 09:40:14,866 INFO Service dnsmasq restart
2020-12-11 09:40:23,530 INFO Processing JSON file
firewall_rules.json.0b59db02-5eb7-44b3-a6d7-2ab3f1ad03b5
2020-12-11 09:40:24,646 INFO Nothing to commit. The
/etc/dnsmasq.d/cloud.conf file did not change
2020-12-11 09:40:24,646 INFO Nothing to commit. The
/var/lib/misc/dnsmasq.leases file did not change
2020-12-11 09:40:24,648 INFO Executing: systemctl is-active dnsmasq
2020-12-11 09:40:24,660 INFO Executing: systemctl reload dnsmasq
2020-12-11 09:40:24,688 INFO Service dnsmasq reload
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
