mbeckerle commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r397971675
##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala
##########
@@ -578,14 +563,13 @@ trait Term
protected def possibleFirstChildTerms: Seq[Term]
/*
- * Returns list of Elements that could be the first child in the infoset
of this model group or element.
- */
+ * Returns list of Elements that could be the first child in the infoset of
this model group or element.
+ */
final lazy val possibleFirstChildElementsInInfoset: Seq[ElementBase] =
LV('possibleFirstChildElementsInInfoset) {
Review comment:
This method seems to be unused and can be deleted. I thought it was deleted,
but it does appear still on master.
The method couldBeLastElementInModelGroup, which has an abstract definition
below, is also not used and it should be deleted. (The implementations of these
are in ModelGroup and ElementBase.)
Ditto for possibleFirstChildTerms above.
Ditto for isSequendceChild above (line 393)
Ditto for possibleNextSiblingTerms below.
I can't put comments directly on the lines, but I walked through this file
looking for unused methods.
hasLaterRequiredSiblings is used only by unit tests, so that AND the unit
tests looking at it can go away.
Same for hasPriorRequiredSiblings.
priorSibling is unused and can be deleted.
Wow, that's quite a bit of code that can be deleted now.
(double check all these - I checked them on master. It's unlikely, but
possible your PR has added a usage of one of these. IDEA's Find Usages is
great.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
