stevedlawrence commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r397978972
##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/GroupRef.scala
##########
@@ -129,18 +131,15 @@ final class ChoiceGroupRef(
refXML: Node,
refLexicalParent: SchemaComponent,
positionArg: Int,
- isHiddenArg: Boolean)
+ override val isHidden: Boolean)
extends ChoiceTermBase(refXML, Option(refLexicalParent), positionArg)
with GroupRef {
requiredEvaluationsIfActivated(groupDef)
private lazy val globalGroupDef = globalGroupDefArg // once only
- override def isHidden = isHiddenArg
- override def isHiddenGroupRef = isHiddenArg
-
- override lazy val groupDef = globalGroupDef
+ override lazy val groupDef = LV('cgrGroupDef){ globalGroupDef }.value
Review comment:
Is it important for the symbol used in the LV match the variable name, maybe
for debugging or diagnostic purposes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
