stevedlawrence commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r397986310
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/GrammarTerm.scala
##########
@@ -94,16 +94,19 @@ abstract class Gram(contextArg: SchemaComponent)
* Note: This should not evaluate the argument unless it has to.
*/
def ~(qq: => Gram) = {
- lazy val q = qq.deref
+ val q = qq.deref
Review comment:
The comment above says this shouldn't evaluate qq unless it needs to. But
this looks like it will always evaluate it now. But maybe it always did that
regardless?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
