mbeckerle commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r397997231
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/PartialNextElementResolver.scala
##########
@@ -76,12 +76,8 @@ trait NextElementResolver { self: InfosetInputter =>
// set of possible elements.
//
maybeERD = resolver.maybeNextElement(name, nameSpace, hasNamespace)
- //
- // If the ERD is marked hidden, then we never expect any events
corresponding
- // to its elements.
- //
- if (maybeERD.isDefined && maybeERD.get.isHidden)
- maybeERD = Nope // clobber it back to Nope
+ // we address the cases where ERD is in a hidden context where the
elements are assigned
Review comment:
Rephrase. "The cases where .... are addressed where..."
I had a hard time following the comment in the current wording.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
