stevedlawrence commented on code in PR #1204:
URL: https://github.com/apache/daffodil/pull/1204#discussion_r1757382607
##########
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala:
##########
@@ -1806,68 +1881,101 @@ object VerifyTestCase {
* @param expectedDiags Expected diagnostics
from test cases
* @param implString Implementation string
*/
- def verifyAllDiagnosticsFound(
+ def verifyDiagnosticsFound(
actualDiags: Seq[Diagnostic],
- expectedDiags: Option[ErrorWarningBase],
+ expectedDiags: Option[Seq[ErrorWarningBase]],
+ ignoreUnexpectedWarnings: Boolean,
Review Comment:
If we use actualDiags then I think it will error if we have any diagnostics,
not just unexpected diagnostics of the right type. Feels like we should pass in
an an enum that says which diag we are checking, or pass in a filter function
that is passed in that is used to pick wich diagnostics to check. Then we don't
have to rely on the expected diags to know which actual diags to compare
against.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
