stevedlawrence commented on code in PR #1204:
URL: https://github.com/apache/daffodil/pull/1204#discussion_r1757401062
##########
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala:
##########
@@ -959,32 +990,45 @@ abstract class TestCase(testCaseXML: NodeSeq, val parent:
DFDLTestSuite) {
protected def checkDiagnosticMessages(
diagnostics: Seq[Diagnostic],
- errors: ExpectedErrors,
- optWarnings: Option[ExpectedWarnings],
+ errors: Seq[ExpectedErrors],
Review Comment:
I imagine some of that can be refactored and simplified now that you've
cleaned up much of this and made things more generic and combined
functionality. Seems all three of those checks can be done with one call to
checkDiagnosticMessages.
I guess we do still need `None` sometimes, since some functions (e.g.
runParseExpectSuccess) don't have access to certain diagnostics because they
expect success and really do need to pass in None. I think maybe the separate
expectSuccess/expectFailure funtions are complicating things a bit, but that
clean up can be done for another day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
