stevedlawrence commented on code in PR #1204:
URL: https://github.com/apache/daffodil/pull/1204#discussion_r1757417240
##########
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala:
##########
@@ -1806,68 +1881,101 @@ object VerifyTestCase {
* @param expectedDiags Expected diagnostics
from test cases
* @param implString Implementation string
*/
- def verifyAllDiagnosticsFound(
+ def verifyDiagnosticsFound(
actualDiags: Seq[Diagnostic],
- expectedDiags: Option[ErrorWarningBase],
+ expectedDiags: Option[Seq[ErrorWarningBase]],
+ ignoreUnexpectedWarnings: Boolean,
Review Comment:
Another alternative, if you update everything to calls
checkDiagnostisMesssages you could do the filter in there, since each call to
verifyDiagnosticFound knows which type it's verifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
