liang-wenjie opened a new pull request, #18464:
URL: https://github.com/apache/dolphinscheduler/pull/18464

   ## Was this PR generated or assisted by AI?
   
   YES. AI assisted with reviewing the previous implementation, refining domain 
naming and compatibility behavior, adding focused tests, and preparing this 
pull request. The changes were reviewed and validated by the contributor.
   
   ## Purpose of the pull request
   
   This pull request adds a schedule-level missed fire policy for Cron 
schedules as an independent part of DSIP #18454.
   
   It is split from the closed PR #18458 so that missed-fire handling can be 
reviewed separately from the fixed-interval trigger design. Fixed-interval 
scheduling is intentionally out of scope for this pull request.
   
   The policy uses scheduler-domain terminology instead of Quartz-specific 
names and keeps the existing Cron scheduling behavior compatible by defaulting 
to `FIRE_ONCE_NOW`.
   
   Related to #18454.
   Supersedes the missed-fire policy portion of #18458.
   
   ## Brief change log
   
   - Add `ScheduleMissedFirePolicy` with `SKIP_MISSED`, `FIRE_ONCE_NOW`, and 
`FIRE_ALL_MISSED`.
   - Persist `missedFirePolicy` in schedule API models and the 
`missed_fire_policy` database column.
   - Map each domain policy to the corresponding Quartz Cron misfire 
instruction.
   - Default missing or legacy policy values to `FIRE_ONCE_NOW` to preserve 
current behavior.
   - Add schedule form options and English/Chinese locale text in the UI.
   - Add unit tests for all three Quartz mappings and the null/default behavior.
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:/n/n- Added 
`QuartzScheduleMissedFirePolicyApplierTest` covering all policies and the 
default behavior.
   - Maven Spotless checks passed for the affected reactor modules.
   - UI Prettier checks passed.
   - UI ESLint checks passed.
   - `vue-tsc --noEmit` passed.
   - Java unit tests could not be executed locally because the local 
environment provides a JRE without `javac`; they are expected to run in CI.
   
   ## Pull Request Notice
   
   [Pull Request 
Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   
   This pull request does not introduce an incompatible change. Existing 
schedules and requests that omit the new field retain the current 
`FIRE_ONCE_NOW` behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to