liang-wenjie commented on code in PR #18464:
URL:
https://github.com/apache/dolphinscheduler/pull/18464#discussion_r3717699442
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ScheduleParam.java:
##########
@@ -31,6 +33,7 @@ public class ScheduleParam {
private Date endTime;
private String crontab;
private String timezoneId;
+ private ScheduleMissedFirePolicy missedFirePolicy =
ScheduleMissedFirePolicy.FIRE_ONCE_NOW;
Review Comment:
You are right. DolphinScheduler uses Quartz 2.3.2, and the current dev
implementation explicitly calls withMisfireHandlingInstructionIgnoreMisfires(),
which maps to MISFIRE_INSTRUCTION_IGNORE_MISFIRE_POLICY. I had incorrectly
reasoned from Quartz SMART_POLICY instead of checking the existing builder
call. Updated in 2868f0960: API/database/UI defaults and null fallback now use
FIRE_ALL_MISSED, and the default factory test verifies the existing
IgnoreMisfires behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
