ruanwenjun commented on code in PR #18464:
URL:
https://github.com/apache/dolphinscheduler/pull/18464#discussion_r3711204176
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ScheduleParam.java:
##########
@@ -31,6 +33,7 @@ public class ScheduleParam {
private Date endTime;
private String crontab;
private String timezoneId;
+ private ScheduleMissedFirePolicy missedFirePolicy =
ScheduleMissedFirePolicy.FIRE_ONCE_NOW;
Review Comment:
Right now, the default misfire policy is `FIRE_ALL_MISSED`?
##########
dolphinscheduler-scheduler-plugin/dolphinscheduler-scheduler-quartz/src/main/java/org/apache/dolphinscheduler/scheduler/quartz/QuartzScheduleMissedFirePolicyApplier.java:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.scheduler.quartz;
+
+import org.apache.dolphinscheduler.common.enums.ScheduleMissedFirePolicy;
+
+import org.quartz.CronScheduleBuilder;
+
+final class QuartzScheduleMissedFirePolicyApplier {
Review Comment:
Don't add this util, it's better to create `CronScheduleBuilderFactory` and
add three different implementation.
##########
dolphinscheduler-ui/src/locales/zh_CN/project.ts:
##########
@@ -148,6 +148,10 @@ export default {
start_time: '开始时间',
end_time: '结束时间',
crontab: 'Crontab',
+ missed_fire_policy: '错过触发策略',
Review Comment:
```suggestion
missed_fire_policy: '定时错过策略',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
