liang-wenjie commented on code in PR #18464:
URL:
https://github.com/apache/dolphinscheduler/pull/18464#discussion_r3717293762
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ScheduleParam.java:
##########
@@ -31,6 +33,7 @@ public class ScheduleParam {
private Date endTime;
private String crontab;
private String timezoneId;
+ private ScheduleMissedFirePolicy missedFirePolicy =
ScheduleMissedFirePolicy.FIRE_ONCE_NOW;
Review Comment:
The previous implementation did not set an explicit policy, so Quartz used
`SMART_POLICY`. In Quartz 2.3.2, `CronTriggerImpl.updateAfterMisfire()`
explicitly translates `SMART_POLICY` to `MISFIRE_INSTRUCTION_FIRE_ONCE_NOW`.
Therefore, I kept `FIRE_ONCE_NOW` as the default to preserve the current
behavior rather than changing existing schedules to `FIRE_ALL_MISSED`.
##########
dolphinscheduler-ui/src/locales/zh_CN/project.ts:
##########
@@ -148,6 +148,10 @@ export default {
start_time: '开始时间',
end_time: '结束时间',
crontab: 'Crontab',
+ missed_fire_policy: '错过触发策略',
Review Comment:
Updated to `定时错过策略` in c73327e. Thanks for the suggestion.
##########
dolphinscheduler-scheduler-plugin/dolphinscheduler-scheduler-quartz/src/main/java/org/apache/dolphinscheduler/scheduler/quartz/QuartzScheduleMissedFirePolicyApplier.java:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.scheduler.quartz;
+
+import org.apache.dolphinscheduler.common.enums.ScheduleMissedFirePolicy;
+
+import org.quartz.CronScheduleBuilder;
+
+final class QuartzScheduleMissedFirePolicyApplier {
Review Comment:
Updated in c73327e. I replaced the util with `CronScheduleBuilderFactory`
and added three separate implementations:
`SkipMissedCronScheduleBuilderFactory`,
`FireOnceNowCronScheduleBuilderFactory`, and
`FireAllMissedCronScheduleBuilderFactory`. The focused test now verifies both
factory selection and the Quartz misfire instruction for each policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
