abhishekrb19 opened a new pull request, #18709: URL: https://github.com/apache/druid/pull/18709
The `GroupByStatsMonitor` helps highlight potential performance bottlenecks on the query and data nodes. For peons, it’s useful to include the `dataSource` and task `id` dimensions to get an aggregated view of merge buffer acquisition times, the number of merge buffer queries per datasource, etc. This is useful for diagnosing identifying bottlenecks on the peons when there's a flurry of realtime group By queries to different tables, so the default tunings are not sufficient. Also, adds missing `@Nullable` annotations to the other monitors and callers that use `DataSourceTaskIdHolder` to get the datasource and task id dimensions. ### Release note The `GroupByStatsMonitor` includes `dataSource` and task `id` dimensions for metrics emitted on the peons. This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [x] a release note entry in the PR description. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
