kfaraz commented on code in PR #18709:
URL: https://github.com/apache/druid/pull/18709#discussion_r2484248484
##########
server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java:
##########
@@ -526,7 +527,7 @@ public static class JettyMonitor extends AbstractMonitor
{
private final Map<String, String[]> dimensions;
- public JettyMonitor(String dataSource, String taskId)
+ public JettyMonitor(@Nullable String dataSource, @Nullable String taskId)
Review Comment:
The `JettyMonitor` is used only for peons. Why should this be a nullable
field?
##########
server/src/main/java/org/apache/druid/server/metrics/DataSourceTaskIdHolder.java:
##########
@@ -46,11 +48,13 @@ public class DataSourceTaskIdHolder
@Inject(optional = true)
BroadcastDatasourceLoadingSpec broadcastDatasourceLoadingSpec =
BroadcastDatasourceLoadingSpec.ALL;
+ @Nullable
Review Comment:
When can this be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
