kfaraz commented on code in PR #18709:
URL: https://github.com/apache/druid/pull/18709#discussion_r2485267386
##########
server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java:
##########
@@ -526,7 +527,7 @@ public static class JettyMonitor extends AbstractMonitor
{
private final Map<String, String[]> dimensions;
- public JettyMonitor(String dataSource, String taskId)
+ public JettyMonitor(@Nullable String dataSource, @Nullable String taskId)
Review Comment:
Ah, of course! Thanks for the clarification.
I don't know why I assumed this class was being used only by the peons. I
have myself depended on the `jetty/*` metrics several times. 😅 .
I think it must have been the presence of the `DatasourceTaskIdHolder` in
the call site which put me in the peon mindset. 😛
---
Since other services are going to use it too, ~let's add a zero-arg
constructor to this class too.~, please accept the dimensions map in the
constructor instead of an explicit datasource and taskID, since these two
fields are very specific to peons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
