kfaraz commented on code in PR #18709:
URL: https://github.com/apache/druid/pull/18709#discussion_r2485306978
##########
server/src/main/java/org/apache/druid/server/metrics/GroupByStatsMonitor.java:
##########
@@ -41,21 +43,28 @@ public class GroupByStatsMonitor extends AbstractMonitor
{
private final GroupByStatsProvider groupByStatsProvider;
private final BlockingPool<ByteBuffer> mergeBufferPool;
+ private final Map<String, String[]> dimensions;
Review Comment:
Maybe rename to `serviceDimensions`?
In fact, I wonder if it wouldn't be cleaner to just bind the datasource and
taskID as `@ExtraServiceDimensions` so that they are used in `EmitterModule`
and are emitted for all metrics emitted by a peon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
