abhishekrb19 commented on code in PR #18709: URL: https://github.com/apache/druid/pull/18709#discussion_r2485097253
########## server/src/main/java/org/apache/druid/server/metrics/DataSourceTaskIdHolder.java: ########## @@ -46,11 +48,13 @@ public class DataSourceTaskIdHolder @Inject(optional = true) BroadcastDatasourceLoadingSpec broadcastDatasourceLoadingSpec = BroadcastDatasourceLoadingSpec.ALL; + @Nullable Review Comment: For peons, the `CliPeon` would [provide](https://github.com/apache/druid/blob/master/services/src/main/java/org/apache/druid/cli/CliPeon.java#L334) the values of `taskId` and `dataSource`. For all other servers, this would be null as these fields are initialized to null:: ```java @Named(DATA_SOURCE_BINDING) @Inject(optional = true) String dataSource = null; @Named(TASK_ID_BINDING) @Inject(optional = true) String taskId = null; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
