abhishekrb19 opened a new pull request, #18732: URL: https://github.com/apache/druid/pull/18732
Refactor: - Move `LookupLoadSpec` and `BroadcastDatasourceLoadingSpec` to a new class called `LoadSpecHolder`. These are applicable to all servers, including `CliPeon` servers. - Rename `DataSourceTaskIdHolder` to `TaskPropertiesHolder`. This is applicable to only `CliPeon` servers. This separation makes the intent clearer, as `DataSourceTaskIdHolder` was previously misleading as it held more than just the dataSource and taskId fields. The `TaskPropertiesHolder` currently contain `taskId` and `dataSource` fields injected from the CliPeon. In the future, we can extend it to also include `groupId` and `taskType` from the Task and add those dimensions to all the metric modules as applicable. This PR has: - [x] been self-reviewed. - [ ] a release note entry in the PR description. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
