kfaraz commented on PR #18732: URL: https://github.com/apache/druid/pull/18732#issuecomment-3556196275
> @kfaraz sorry I ran into some hiccups with the bindings last week and didn't get a chance to take a closer look, but I'm hoping to revive this change again soon. No worries, @abhishekrb19 ! 🙂 > Given that there are some subtle differences between indexers and MMs, do you have any suggestions for embedded tests that use MMs? If the purpose is to test out peons in an embedded test setup, you could do a couple of things: - Use `EmbeddedMiddleManager` and annotate it `@SuppressForbidden(reason = "EmbeddedMiddleManager#init")` - Use the k3s environment with the help of `K3sClusterResource`, e.g. `KubernetesClusterDockerTest` (These tests would run in the `docker-tests` GHA workflow. It is also possible to run them locally after setting the `druid.testing.docker.image` property.) For local testing, please feel free to update any test to use an MM instead of Indexer. Most of them should work fine for both Indexer and MM. But while committing, I would also advise not to change any of the existing tests to use MMs (since Indexers are faster and easier to debug) and add new MM-flavored variants of any test where necessary. Please let me know if this meets yours needs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
