abhishekrb19 commented on PR #18732: URL: https://github.com/apache/druid/pull/18732#issuecomment-3556135208
@kfaraz sorry I ran into some hiccups with the bindings last week and didn't get a chance to take a closer look, but I'm hoping to revive this change again soon. Btw I noticed this deprecated comment on [EmbeddedMiddleManager](https://github.com/apache/druid/blob/master/services/src/test/java/org/apache/druid/testing/embedded/EmbeddedMiddleManager.java#L36), so most (or all?) the tests seem to use the indexer for good reasons. Given that there are some subtle differences between indexers and MMs, do you have any suggestions for embedded tests that use MMs? At the very least, I was thinking of updating some of the embedded tests to use `EmbeddedMiddleManager` instead of `EmbeddedIndexer` locally. I’m also planning to add some unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
