github-advanced-security[bot] commented on code in PR #18732:
URL: https://github.com/apache/druid/pull/18732#discussion_r2558102250
##########
services/src/test/java/org/apache/druid/cli/CliPeonTest.java:
##########
@@ -229,6 +468,27 @@
static final String TYPE = "testStreaming";
static final String STATUS =
SeekableStreamIndexTaskRunner.Status.PAUSED.toString();
+ public TestStreamingTask(
+ String id,
+ @Nullable String supervisorId,
+ String datasource,
Review Comment:
## Useless parameter
The parameter 'datasource' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/10565)
##########
server/src/main/java/org/apache/druid/query/lookup/LookupListeningAnnouncerConfig.java:
##########
@@ -50,7 +55,7 @@
!(lookupTierIsDatasource && null != lookupTier),
"Cannot specify both `lookupTier` and `lookupTierIsDatasource`"
);
- final String lookupTier = lookupTierIsDatasource ?
dataSourceTaskIdHolder.getDataSource() : this.lookupTier;
+ final String lookupTier = lookupTierIsDatasource ?
taskHolder.getDataSource() : this.lookupTier;
Review Comment:
## Possible confusion of local and field
Confusing name: method [getLookupTier](1) also refers to field
[lookupTier](2) (without qualifying it with 'this').
[Show more
details](https://github.com/apache/druid/security/code-scanning/10566)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
