kfaraz commented on PR #18732: URL: https://github.com/apache/druid/pull/18732#issuecomment-3510032630
Ah, I see, thanks for clarifying that, @abhishekrb19 ! All the current usages of `DatasourceTaskIdHolder` are indeed in the `druid-server` module. In that case, I think we should add an interface `TaskHolder` to `druid-server` and use it wherever needed. Bind the `TaskHolder` to a `PeonTaskHolder` in `CliPeon` and bind it elsewhere to a `NoopTaskHolder` which throws `UnsupportedOperationException` upon calling any method. I feel this clarifies the intent better and makes it more extensible for the future. Sound good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
