abhishekrb19 commented on PR #18732: URL: https://github.com/apache/druid/pull/18732#issuecomment-3509959969
Thanks for the review, @kfaraz! I think the approach of keeping one renamed class would work well and makes sense. Just one caveat: the `Task` class is in the `indexing-service` module, so we can’t use it directly in the `server` module. However, we could create a constructor that accepts all the task properties as primitives and have it `@Provides` from `CliPeon` like you suggested, along with a default constructor for all other servers. This way, we can remove all the individual `@Named` annotation bindings from CliPeon. Does that work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
