abhishekrb19 commented on code in PR #18732:
URL: https://github.com/apache/druid/pull/18732#discussion_r2573303880
##########
server/src/main/java/org/apache/druid/server/metrics/MetricsModule.java:
##########
@@ -110,9 +108,10 @@ public MonitorScheduler getMonitorScheduler(
{
List<Monitor> monitors = new ArrayList<>();
// HACK: when ServiceStatusMonitor is the first to be loaded, it
introduces a circular dependency between
- // CliPeon.runTask and
CliPeon.getDataSourceFromTask/CliPeon.getTaskIDFromTask. The reason for this is
unclear
- // but by injecting DataSourceTaskIdHolder early this cycle is avoided.
- injector.getInstance(DataSourceTaskIdHolder.class);
+ // CliPeon.runTask and TaskHolder.getDataSource()/TaskHolder.getTaskId().
The reason for this is unclear
+ // but by injecting TaskPropertiesHolder early this cycle is avoided.
Review Comment:
Ah yes, good point, they're no longer required. I've removed the changes
originally included in https://github.com/apache/druid/pull/16140 and added
some tests that would otherwise fail if we remove this "hack".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
