gianm commented on a change in pull request #8047: optimize single input column
multi-value expressions
URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309489998
##########
File path: core/src/main/java/org/apache/druid/math/expr/Expr.java
##########
@@ -304,7 +334,37 @@ public BindingDetails withArrayArguments(Set<Expr>
arrayArguments)
return new BindingDetails(
ImmutableSet.copyOf(Sets.union(freeVariables, arrayIdentifiers)),
scalarVariables,
- ImmutableSet.copyOf(Sets.union(arrayVariables, arrayIdentifiers))
+ ImmutableSet.copyOf(Sets.union(arrayVariables, arrayIdentifiers)),
+ hasInputArrays || arrayArguments.size() > 0,
Review comment:
Is it possible for `arrayArguments.size()` to be greater than zero, but
`hasInputArrays` to be false? If so how? (Related to previous comment, I think)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
