gianm commented on a change in pull request #8047: optimize single input column
multi-value expressions
URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309491377
##########
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##########
@@ -76,6 +76,22 @@
return Collections.emptySet();
}
+ /**
+ * Returns true if a function takes an array arguments
+ */
+ default boolean hasArrayInputs()
+ {
+ return false;
+ }
+
+ /**
+ * Returns true if function produces an array
Review comment:
What happens if it sometimes produces an array, and sometimes doesn't, based
on its input type? Similar comment to `ApplyFunction.hasArrayOutput`: is it
disallowed, or should it return true/false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
