gianm commented on a change in pull request #8047: optimize single input column
multi-value expressions
URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309491269
##########
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##########
@@ -76,6 +76,22 @@
return Collections.emptySet();
}
+ /**
+ * Returns true if a function takes an array arguments
Review comment:
1. "takes array arguments" or "takes an array argument" (grammar, and also,
I'm not sure which one you mean; the two phrases mean different things)
2. Clarify intent: what does "takes an array arguments" mean? That it
_might_ take array arguments? Or that it _must_ take array arguments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
