gianm commented on a change in pull request #8047: optimize single input column
multi-value expressions
URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309472589
##########
File path:
processing/src/test/java/org/apache/druid/query/groupby/GroupByQueryRunnerTest.java
##########
@@ -974,15 +973,9 @@ public void testGroupByWithStringPostAggregator()
public void testGroupByWithStringVirtualColumn()
{
// Cannot vectorize due to virtual columns.
+ // all virtual columns are single input column, so it will work for group
by v1, even with multi-value inputs
Review comment:
🆒 it's quite nice that this test can pass again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
