gianm commented on a change in pull request #8047: optimize single input column
multi-value expressions
URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309490852
##########
File path: core/src/main/java/org/apache/druid/math/expr/Expr.java
##########
@@ -824,7 +888,12 @@ public BindingDetails analyzeInputs()
}
lambdaBindingDetails = lambdaExpr.analyzeInputs();
- bindingDetails =
accumulator.with(lambdaBindingDetails).withArrayArguments(function.getArrayInputs(argsExpr));
+ boolean isArrayOutput = function.hasArrayOutput() || (function instanceof
ApplyFunction.BaseFoldFunction
Review comment:
Using `instanceof` here seems like a code smell -- is there a nice way to
add a method to `ApplyFunction` that gets the necessary info out?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
