gianm commented on a change in pull request #8047: optimize single input column
multi-value expressions
URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309489786
##########
File path: core/src/main/java/org/apache/druid/math/expr/Expr.java
##########
@@ -248,6 +256,24 @@ public BindingDetails(
return
arrayVariables.stream().map(IdentifierExpr::getIdentifier).collect(Collectors.toSet());
}
+ /**
+ * Returns true if the expression has any array inputs. Note that in some
cases, this can be true and
+ * {@link BindingDetails#getArrayVariables} can be empty, since the latter
can only shallowly collect identifiers
+ * that are explicitly used as arrays.
Review comment:
I turned this comment over a few times in my mind but don't quite understand
it. What does "shallowly" mean in this context and what is "deeper" about
`hasInputArrays`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
