leventov commented on a change in pull request #8809: Prohibit
Futures.addCallback(Future, Callback)
URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r347088068
##########
File path:
server/src/main/java/org/apache/druid/server/http/SegmentListerResource.java
##########
@@ -205,7 +209,8 @@ public void onFailure(Throwable th)
log.debug(ex, "Request timed out or closed already.");
}
}
- }
+ },
Review comment:
Ok, but the comments that you left right here don't make anything clearer.
It's ok to omit them in this PR and instead write better comments as part of
that PR that you planned, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
