leventov commented on a change in pull request #8809: Prohibit
Futures.addCallback(Future, Callback)
URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r347087847
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/worker/WorkerTaskManager.java
##########
@@ -177,6 +177,9 @@ public void stop() throws Exception
return completedTasks;
}
+ /**
+ * This method is mostly non-blocking because exec is a ThreadPoolExecutor
with unbounded queue used by default.
Review comment:
Please make `exec` and `ThreadPoolExecutor` javadoc links
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
