leventov commented on a change in pull request #8809: Prohibit
Futures.addCallback(Future, Callback)
URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r347088004
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java
##########
@@ -257,7 +257,7 @@ public void onFailure(Throwable throwable)
}
}
},
- // The callback is non-blocking and quick, so it's OK to
schedule it using directExecutor()
+ // The callback is mostly non-blocking and quick, so it's
OK to schedule it using directExecutor()
Review comment:
[In my
comment](https://github.com/apache/incubator-druid/pull/8809#discussion_r342940649),
I wrote "*you may argue that*... this code is mostly non-blocking", I didn't
*state* that (and I actually don't know). I. e. the fact that the synchronized
block in `onSuccess()` "is mostly non-blocking" requires some proof, expressed
in a comment. There is not enough information to make such proof (or disproof)
just in this code excerpt in Github's interface. A wider context (specifically,
the code which synchronizes on `waitingForMonitor` and waits) should be
considered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
