leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r354938025
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java ########## @@ -175,6 +175,7 @@ private final ConcurrentMap<String, ScheduledFuture> removedWorkerCleanups = new ConcurrentHashMap<>(); private final ProvisioningStrategy<WorkerTaskRunner> provisioningStrategy; + private final ExecutorService monitorSyncHandler; Review comment: This extra service must be explicitly shutdown in `stop()`/`close()`, see https://github.com/code-review-checklists/java-concurrency#explicit-shutdown. Applies to other classes in this PR as well ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
