leventov commented on a change in pull request #8809: Prohibit
Futures.addCallback(Future, Callback)
URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r347087802
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java
##########
@@ -560,6 +560,7 @@ private void handleStatus(final TaskStatus status)
}
}
},
+ //Using dedicated statusHandler executor instead of directExecutor()
because the callback's onSuccess() is not trivial and because the statusFuture
is completed in some incapsulated thread pool in TaskRunner; directExecutor()
may create operational instability and subtle dependency between components
here. See
https://github.com/code-review-checklists/java-concurrency#cf-beware-non-async
for details
Review comment:
Line longer than 120 columns
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
