clintropolis commented on a change in pull request #9161: refactor numeric
first/last aggregators to fix null handling bugs
URL: https://github.com/apache/druid/pull/9161#discussion_r368154212
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/last/DoubleLastAggregatorFactory.java
##########
@@ -230,7 +248,7 @@ public String getTypeName()
@Override
public int getMaxIntermediateSize()
{
- return Long.BYTES + Double.BYTES;
+ return Long.BYTES + Double.BYTES + 1;
Review comment:
it seems unlikely to me that the number of bytes in a byte is not going to
change, but ok :p
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
